New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: play_card function with second_swipe support #2330
base: future3/develop
Are you sure you want to change the base?
fix: play_card function with second_swipe support #2330
Conversation
Regarding "second swipe": That's definitely another behaviour known from V2. Nevertheless would it not make more sense that it is an option on the folder/card, then an overall state? So different cards could have different settings? |
I agree
I don't think that's the case. See below explanation.
I haven't deep dived into the v2 implementation much.
I agree Intuitively, we opted for the commands Initially, I questioned the necessity of Nonetheless, combining the if(second_swipe): next() # Avoid triggering play_album() This is likely the rationale behind the original implementation within the Player, as it was the only entity capable of managing this logic. I am dissatisfied with the current implementation of the second swipe functionality and propose its removal, with the intention of reintroducing it in a separate PR. |
#1698 is related and probably needs to be considered. |
Until now, 3 functions existed to be registered to a card:
play_single
,play_album
andplay_folder
. None of these functions supported "Second Swipe". Instead, another function existed, calledplay_card
which had Second Swipe support, but it ended up to callplay_folder
, ingoring the other 2 functions all togetherThis PR aims at solving this problem and to prepare for hoffie@c4805ce
play_card
inPlayerMPD
play_card
command instead ofplay_single
,play_album
orplay_folder
play_card