Multi Player Support

[Groovylein]

Ground work for multiple players.

Basis to solve Spotify issues or other streaming services on future3, see #1815 and #2116

[coveralls]

Pull Request Test Coverage Report for Build 8924248257

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 38.235%

---

Totals
Change from base Build 8775015840:	0.0%
Covered Lines:	494
Relevant Lines:	1292

---

💛 - Coveralls

[pabera]

Please don't commit this :-) It'll be vey verbose and irrelevant

[AlvinSchiller]

Sry for getting at it again, but i still think this should be ${HOME} as it is supplied as args and defaults to "root".
So right now if the user will provide different values it breaks.

[s-martin]

Does this still belong to the Spotify PR?

[s-martin]

Shouldn’t this be player agnostic?

[s-martin]

For reference this PR is the base for #2116

[pabera]

To reduce repetition in your class MPDBackend, where you frequently update self.player_status, you could introduce a decorator that handles the status updates. This way, you won't have to manually call self.player_status.update(playing=True/False) in every method where this is needed. This also keeps your method implementations cleaner and focused on their primary responsibilities.

Decorator Definition (not sure it works directly, but should be close)

def update_player_status(playing=None):
    def decorator(func):
        def wrapper(self, *args, **kwargs):
            result = func(self, *args, **kwargs)
            if playing is not None:
                self.player_status.update(playing=playing)
            return result
        return wrapper
    return decorator

Use the Decorator in Your Class

Apply this decorator to the methods of your MPDBackend class. For methods that set the player to play, pass playing=True, and for those that pause or stop, pass playing=False. You can skip the parameter for methods that don't change the playing status.

class MPDBackend(BackendPlayer): 
    @plugin.tag
    @update_player_status(playing=True)
    def play(self):
        self._active.play()
        
    ...
    @plugin.tag
    @update_player_status()
    def toggle(self):
        self._active.toggle()
        # Dynamically determines playing status based on current state
        current_playing = self.player_status.get_value('playing')
        self.player_status.update(playing=not current_playing)
    
    @plugin.tag
    @update_player_status(playing=False)
    def stop(self):
        self._save_state()
        self._active.stop()

[pabera]

I like this! The Timer Classes are pretty well done and can be used for such use cases nicely!

[pabera]

Looks rather annoying to add self.player_status.update(playing=True/False) everywhere. You could use a decorator approach, maybe even in the BackendPlayer class (to be verified).

We already use decorators with @plugin.tag.