Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second swipe defect after playlist runs out #1698

Open
ghost opened this issue Jan 1, 2022 · 4 comments · May be fixed by #2330
Open

Second swipe defect after playlist runs out #1698

ghost opened this issue Jan 1, 2022 · 4 comments · May be fixed by #2330
Labels
bug future3 Relates to future3 development

Comments

@ghost
Copy link

ghost commented Jan 1, 2022

Describe your problem

Second swipe does not decode to first swipe after playlist has runs out. This means that the same playlist cannot be started again when Second Swipe is enabled w/o playing something else in between
@ghost ghost added bug future3 Relates to future3 development labels Jan 1, 2022
@ghost ghost self-assigned this Jan 1, 2022
@lenlennart
Copy link
Contributor

see #1520 . There is also a pending PR for 2.x release

@ghost
Copy link
Author

ghost commented Jan 20, 2022

@lenlennart: Thanks for linking to the issue and committing a PR with a fix. Version 2 and Version 3 have an entirely different code base and I am an maintainer only for Version 3 - so cannot merge your PR. Still an important issue also for Version 3: it's a situation that I did not have in mind, yet. I will check it.

@lenlennart
Copy link
Contributor

still, the source of the problem might be the same: mpc beeing send to "pause" on removal of card, regardless of current playing state -> you should check for status = "play".

@ghost
Copy link
Author

ghost commented Jan 21, 2022

You are right there! Thanks for making the connection.

@s-martin s-martin linked a pull request Apr 15, 2024 that will close this issue
fix: play_card function with second_swipe support #2330
Open
3 tasks
@s-martin s-martin linked a pull request Apr 15, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug future3 Relates to future3 development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: play_card function with second_swipe support pabera/RPi-Jukebox-RFID
1 participant
@lenlennart