Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start in background mode #2841

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Start in background mode #2841

wants to merge 11 commits into from

Conversation

JosephJin0815
Copy link

This is a review for the new CreationPriority API.

@JosephJin0815 JosephJin0815 added the API Proposal Review WebView2 API Proposal for review. label Sep 30, 2022
} COREWEBVIEW2_CREATION_PRIORITY;

[uuid(efb58776-32bd-11ed-a261-0242ac120002), object, pointer_default(unique)]
interface ICoreWebView2EnvironmentOptions3 : ICoreWebView2EnvironmentOptions2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking to @LiangTheDev we should move CreationPriority to the CoreWebView2Environment. In the future we may want to support changing the priority during creation.

/// process still get created with normal priority even with `COREWEBVIEW2_CREATION_PRIORITY_HIGH`
/// setting. Additionally, currently `CreationPriority` only applies to the creation of the
/// WebView2 browser process. `CreationPriority` may be broadened to apply to other parts of
/// WebView2 creation in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also update this note to suggest how we could change this in the future.

Suggested change
/// WebView2 creation in the future.
/// WebView2 creation and may apply to in progress WebView2 creation in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Proposal Review WebView2 API Proposal for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants