Fixing code on the guide on implementing Pattern availability #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the text, it is said that when we need to fallback to the base class, we call the `GetPatternCore`, but in the code, it was just `GetPattern`, which can cause a stack overflow as it will be calling itself forever.
|
@guimafelipe : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
prmerger-automator
bot
added
apps/subsvc
Change sent to author
windows-app-sdk/svc
labels
|
Learn Build status updates of commit b3e8783: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the text, it is said that when we need to fallback to the base class, we call the
GetPatternCore, but in the code, it was justGetPattern, which can cause a stack overflow as it will be calling itself forever.