-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apple-sso-plugin.md for rebranding #751
base: main
Are you sure you want to change the base?
Conversation
Rebrand, “Windows Account” extension to the “Microsoft Single Sign On”. And adding additional information.
@ejahja : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 217c666:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/identity-platform/apple-sso-plugin.md | Details |
docs/identity-platform/apple-sso-plugin.md
- Line 438, Column 139: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 438, Column 139: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
To support device Conditional Access policies in Google Chrome with Secure Enclave based storage enabled, you will need to have the [Windows Accounts](https://chromewebstore.google.com/detail/windows-accounts/ppnbnpeolgkicgegkbkbjmhlideopiji) extension installed and enabled. | ||
To support device Conditional Access policies in Google Chrome with Secure Enclave based storage enabled, you will need to have the [Microsoft Single Sign On](https://chromewebstore.google.com/detail/windows-accounts/ppnbnpeolgkicgegkbkbjmhlideopiji) extension installed and enabled. | ||
|
||
1. This is required for Mac devices that enable Platform SSO and for devices that have opted-in to Secure Enclave backed device identity (https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can omit bullet #1 here since the surrounding section of this document covers this.
I'd suggest turning #2 into a Note like...
Tip: Admins can automatically deploy Chrome Extensions using MDM (learn more).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just committed, please review when you can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cleanup suggested
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
Brian recommended some changes
Learn Build status updates of commit a9a4ab4:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/identity-platform/apple-sso-plugin.md | Details |
docs/identity-platform/apple-sso-plugin.md
- Line 438, Column 136: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 438, Column 136: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Co-authored-by: Brian Melton-Grace <iambmelton@gmail.com>
Learn Build status updates of commit 57a0a5f:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/identity-platform/apple-sso-plugin.md | Details |
docs/identity-platform/apple-sso-plugin.md
- Line 438, Column 136: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 438, Column 136: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Rebrand, “Windows Account” extension to the “Microsoft Single Sign On”. And adding additional information.