Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apple-sso-plugin.md for rebranding #751

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ejahja
Copy link
Contributor

@ejahja ejahja commented May 1, 2024

Rebrand, “Windows Account” extension to the “Microsoft Single Sign On”. And adding additional information.

Rebrand, “Windows Account” extension to the “Microsoft Single Sign On”. And adding additional information.
Copy link
Contributor

@ejahja : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 217c666:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity-platform/apple-sso-plugin.md ⚠️Warning Details

docs/identity-platform/apple-sso-plugin.md

  • Line 438, Column 139: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 438, Column 139: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

To support device Conditional Access policies in Google Chrome with Secure Enclave based storage enabled, you will need to have the [Windows Accounts](https://chromewebstore.google.com/detail/windows-accounts/ppnbnpeolgkicgegkbkbjmhlideopiji) extension installed and enabled.
To support device Conditional Access policies in Google Chrome with Secure Enclave based storage enabled, you will need to have the [Microsoft Single Sign On](https://chromewebstore.google.com/detail/windows-accounts/ppnbnpeolgkicgegkbkbjmhlideopiji) extension installed and enabled.

1. This is required for Mac devices that enable Platform SSO and for devices that have opted-in to Secure Enclave backed device identity (https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can omit bullet #1 here since the surrounding section of this document covers this.

I'd suggest turning #2 into a Note like...

Tip: Admins can automatically deploy Chrome Extensions using MDM (learn more).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just committed, please review when you can

Copy link
Contributor

@iambmelt iambmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup suggested

@Court72
Copy link
Contributor

Court72 commented May 2, 2024

@henrymbuguakiarie

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Brian recommended some changes
Copy link
Contributor

Learn Build status updates of commit a9a4ab4:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity-platform/apple-sso-plugin.md ⚠️Warning Details

docs/identity-platform/apple-sso-plugin.md

  • Line 438, Column 136: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 438, Column 136: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Co-authored-by: Brian Melton-Grace <iambmelton@gmail.com>
Copy link
Contributor

Learn Build status updates of commit 57a0a5f:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity-platform/apple-sso-plugin.md ⚠️Warning Details

docs/identity-platform/apple-sso-plugin.md

  • Line 438, Column 136: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 438, Column 136: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/apple-sso-plugin#registeredenrolled-device-conditional-access-policy-support-in-chrome' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants