Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate "Privacy, search, and services" into "Privacy and security" & "Search and services" #3127

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Apr 11, 2024

Rendered article for review:

Microsoft Edge > Settings and more > Settings > Privacy, search, and services is getting split into two sections:

  • Privacy and security
  • Search and services

That change impacts the Microsoft Edge Privacy Whitepaper, which mentions the old combined section, and mentions "edge://settings/privacy" 36 times. Two other articles also mention "edge://settings/privacy".

The goal of this PR is to ready the docs for when the combined section will get replaced by the two new sections in the near future.

This PR also makes the following changes:

  • Normalizes how the Settings and more GUI nav path is described, and replaces (...) by an icon.
  • Starts moving away from special "shortcut" urls (edge://settings/privacy) toward standard GUI nav path instead, providing a wording patttern/ Markdown template to propagate.
  • Removes screenshots that show the old UI; replaced by standard wording of GUI nav path.

AB#50096302

@captainbrosset captainbrosset changed the title Document the new **Privacy and security** and **Search and services** settings Document the new Privacy and security and Search and services settings Apr 11, 2024
@mikehoffms mikehoffms changed the title Document the new Privacy and security and Search and services settings Document the new "Privacy and security" & "Search and services" settings Apr 11, 2024
@mikehoffms mikehoffms added the on-hold The changes are currently on-hold and awaiting further evaluation. label Apr 11, 2024
@captainbrosset captainbrosset marked this pull request as ready for review April 11, 2024 16:18
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor review: Move away from heavy reliance on special urls; state the GUI nav path instead.

@mikehoffms mikehoffms marked this pull request as draft April 11, 2024 18:51
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per Writer/Editor review, after pushing commits to reword from special shortcut URL edge://settings/privacy to standard GUI nav path format.
Caveat: Don't have latest UI, to check GUI nav path & UI strings.

Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR per Writer/Editor review

@mikehoffms mikehoffms changed the title Document the new "Privacy and security" & "Search and services" settings Separate "Privacy, search, and services" settings into "Privacy and security" & "Search and services" Apr 18, 2024
@mikehoffms mikehoffms changed the title Separate "Privacy, search, and services" settings into "Privacy and security" & "Search and services" Separate "Privacy, search, and services" into "Privacy and security" & "Search and services" Apr 18, 2024
Copy link

Learn Build status updates of commit af343e3:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/privacy-whitepaper/index.md ✅Succeeded View
microsoft-edge/privacy-whitepaper/index-images/rewardssettings.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/privacy-whitepaper/index-images/settings-and-more-icon.png ✅Succeeded View
microsoft-edge/privacy-whitepaper/index-images/tabgroupsettings.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/web-platform/tracking-prevention.md ✅Succeeded View
microsoft-edge/web-platform/tracking-prevention-images/settings-and-more-icon.png ✅Succeeded View
microsoft-edge/webview2/concepts/data-privacy.md ✅Succeeded View
microsoft-edge/webview2/concepts/data-privacy-images/settings-and-more-icon.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: privacy on-hold The changes are currently on-hold and awaiting further evaluation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants