-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign WebView2 TOC & clarify article titles #3124
Draft
mikehoffms
wants to merge
17
commits into
main
Choose a base branch
from
wv2-toc
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehoffms
added
on-hold
The changes are currently on-hold and awaiting further evaluation.
in-progress
labels
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat: webview2
WebView-related content.
in-progress
on-hold
The changes are currently on-hold and awaiting further evaluation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered TOC for review:
https://review.learn.microsoft.com/microsoft-edge/webview2/?branch=pr-en-us-3124
Before:
https://learn.microsoft.com/microsoft-edge/webview2/
Confirmed that each article in live TOC exists in PR's rendered TOC.
Objectives of this TOC redesign:
This PR also makes the following changes:
"Understand the different WebView2 SDK versions"
to:
"Prerelease and Release SDKs for WebView2"
to be more specific (than "versions") and provide the key words.
https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/concepts/versioning?branch=pr-en-us-3124
https://review.learn.microsoft.com/en-us/microsoft-edge/webview2/how-to/communicate-btwn-web-native?branch=pr-en-us-3124
Mapping from existing TOC (left) to redesigned TOC (right):
This PR 3124 replaces forked July 2023 PR #2725, which lists the irrelevant file archive.md as entirely changed by that PR, yet not at all changed by that PR.
AB#50063950