Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network-observability-managed-cli.md #122473

Merged
merged 1 commit into from
May 21, 2024

Conversation

Khushbu-Parekh
Copy link
Contributor

Some fixes to the Network Observability docs

Some fixes to the Network Observability docs
Copy link
Contributor

@Khushbu-Parekh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit c0a983b:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/network-observability-managed-cli.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@huntergregory
Copy link
Contributor

Fixes #122336

Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. One thought, wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wdyt about adding this clarification too? "If not running, make sure to azure monitor metrics is enabled (see step above)"

here:

  1. Use the following example to verify the Azure Monitor pods are running.

@Jak-MS
Copy link
Contributor

Jak-MS commented May 13, 2024

@asudbring

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label May 13, 2024
@Khushbu-Parekh
Copy link
Contributor Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @asudbring

@asudbring
Copy link
Contributor

#sign-off

@Court72
Copy link
Contributor

Court72 commented May 14, 2024

Due to the upcoming Build conference, all merging and publishing is on hold until the morning of 5/21.

This PR is ready for merge on 5/21.

#label: "event-triaged-to-10AM"
#label: "missed-content-complete"

@Court72 Court72 merged commit 2be7e71 into MicrosoftDocs:main May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants