Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed function "import from" location #1495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harristemuri
Copy link

isAggregateLogsUploadError was being pulled from @azure/identity for the "Upload custom logs" example when it should be imported from @azure/monitor-ingestion

isAggregateLogsUploadError was being pulled from @azure/identity for the "Upload custom logs" example when it should be imported from @azure/monitor-ingestion
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5233a43:

⚠️ Validation status: warnings

File Status Preview URL Details
docs-ref-services/latest/monitor-ingestion-readme.md ⚠️Warning View (azure-node-latest) Details

docs-ref-services/latest/monitor-ingestion-readme.md

  • Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'monitor'.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
  • Line 13, Column 75: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/overview' will be broken in isolated environments. Replace with a relative link.
  • Line 13, Column 125: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/logs/logs-ingestion-api-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 21, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/overview' will be broken in isolated environments. Replace with a relative link.
  • Line 29, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/essentials/data-collection-endpoint-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 30, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/essentials/data-collection-rule-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 31, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/logs/log-analytics-workspace-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 43, Column 94: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/javascript/api/@azure/core-auth/tokencredential?view=azure-node-latest' will be broken in isolated environments. Replace with a relative link.
  • Line 43, Column 94: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/javascript/api/@azure/core-auth/tokencredential?view=azure-node-latest
  • Line 64, Column 104: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/essentials/data-collection-endpoint-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 78, Column 28: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/essentials/data-collection-rule-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 78, Column 140: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/logs/tutorial-logs-ingestion-portal#collect-information-from-the-dcr' will be broken in isolated environments. Replace with a relative link.
  • Line 85, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/reference/tables/commonsecuritylog' will be broken in isolated environments. Replace with a relative link.
  • Line 86, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/reference/tables/securityevent' will be broken in isolated environments. Replace with a relative link.
  • Line 87, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/reference/tables/syslog' will be broken in isolated environments. Replace with a relative link.
  • Line 88, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/reference/tables/windowsevent' will be broken in isolated environments. Replace with a relative link.
  • Line 99, Column 96: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/service-limits#custom-logs' will be broken in isolated environments. Replace with a relative link.
  • Line 271, Column 44: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/overview' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant