Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console improvements #441

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Console improvements #441

wants to merge 1 commit into from

Conversation

AndrewNelis
Copy link

This pull request attempts to make the console plugin behave like a regular browser console:

  1. We call an alias of eval which does the same thing but evaluates in the global scope. ( https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval#Description - see last example ). Otherwise I think if you try to define a variable, it's just defined in the local scope of evalOrderFromDashboard.
  2. We call console.log on the command we're about to execute. This is just to leave a log of it in the console log. Again, to make it look like a normal console.
  3. I removed the isLoggable logic and decided that all responses should be logged.
  4. Removed "unable to execute order" - just show the error in the console!
  5. Don't pass boolean or undefined types to inspect - just pass back as string. Think this should fix Booleans shows as [Object] and cannot be expanded #419.

* Evaluates command in global env
* Input/Output messages look more like regular browser console.
@msftclas
Copy link

msftclas commented Nov 21, 2018

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants