Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]A11y_VSCode_KeyboardShortcuts_ScreenReader: NVDA is reading "Search Keybindings" twice. #52030

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 15, 2018 · 3 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) keybindings-editor Keybinding editor issues windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10

Additional Details:
Screenreader,NVDA[2018.2],MAS1.3.1

Repro Steps:
1.Launch VS Code while NVDA is ON.
2.Navigate to Settings icon in Activity Bar->Press Enter->Select "Keyboard Shortcuts" from dropdown.
3.Navigate to "Search Keybinding" edit text field
4.Observed that screenreader is reading "Search Keybinding" twice.

Actual:
While reading through the screen reader as NVDA, it is reading "Search Keybinding" edit text field twice.
here, NVDA is reading "Search Keybinding" edit "Search Keybinding"

Expected:
NVDA should reads the button name as "Change Keybinding" button along with the placeholder value

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
User will not understand the placeholer text and exact value of placeholder becuase NVDA reads the both placeholder text as well as placeholder value.

MAS Reference:
MAS1.3.1- https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference:
[Accessibility]A11y_VSCode_KeyboardShortcuts_ScreenReader.pptx

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 15, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 18, 2018
@sandy081 sandy081 added keybindings-editor Keybinding editor issues and removed search Search widget and operation issues labels Jun 19, 2018
@sandy081 sandy081 modified the milestones: July 2018, June 2018 Jun 19, 2018
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 3, 2018
@vscodebot
Copy link

vscodebot bot commented Jul 3, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jul 3, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 3, 2018

#51999

@joaomoreno joaomoreno removed the bug Issue identified by VS Code Team member as probable bug label Aug 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 17, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) keybindings-editor Keybinding editor issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

6 participants