Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA is not reading "Change Keybinding" button name #52027

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 15, 2018 · 6 comments
Closed
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues keybindings VS Code keybinding issues keybindings-editor Keybinding editor issues windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10

Additional Deatils:
Screenreader,NVDA[2018.2],MAS1.3.1

Repro Steps:
1.Launch VS Code while NVDA is ON.
2.Navigate to Settings icon in Activity Bar->Press Enter->Select "Keyboard Shortcuts" from dropdown.
3.Navigate to "Change Keybinding" button.
4.Observed that screenreader is not reading the name of button.

Actual:
NVDA is not reading the "Change Keybinding" button name.This button is actionable and NVDA is not reading it.

Expected:
NVDA should reads the button name as "Change Keybinding" button.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
Screenreader is not reading button name because of that, user will bot understand where the keyboard focus is and what action user have to perform.
User will not take appropriate action on the button becuase narrator is not announcing it's name.

MAS Reference:
MAS1.3.1- https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference:
[Accessibility]A11y_VSCode_KeyboardShortcuts_ScreenReader.pptx
Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane RMacfarlane added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues keybindings VS Code keybinding issues keybindings-editor Keybinding editor issues labels Jun 15, 2018
@sandy081 sandy081 modified the milestones: June 2018, July 2018 Jun 18, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

I can repro this, and I feel like this is law hanging fruit, let's leave it for July

@isidorn isidorn changed the title [Accessibility]A11y_VSCode_KeyboardShortcuts_ScreenReader: NVDA is not reading "Change Keybinding" button name. NVDA is not reading "Change Keybinding" button name Jul 4, 2018
@sandy081
Copy link
Member

sandy081 commented Jul 6, 2018

This is an action item with title, not sure why the screen reader is not reading the title.

@bpasero any idea?

@bpasero
Copy link
Member

bpasero commented Jul 6, 2018

@sandy081 @isidorn this fails for any action within tree/list, check with @joaomoreno

@isidorn
Copy link
Contributor

isidorn commented Jul 17, 2018

Also assigning to @joaomoreno and me so we investigate

@joaomoreno
Copy link
Member

Duplicate of #52682

@joaomoreno joaomoreno marked this as a duplicate of #52682 Jul 19, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 2, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues keybindings VS Code keybinding issues keybindings-editor Keybinding editor issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

7 participants