New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Middleware Decorator to Resolver #1297
Open
xcfox
wants to merge
8
commits into
MichalLytek:master
Choose a base branch
from
xcfox:feat-scoping-middlewares
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalLytek
added
Enhancement 🆕
New feature or request
Community 👨👧
Something initiated by a community
labels
Jun 21, 2022
@xcfox does this work with |
MichalLytek
force-pushed
the
master
branch
4 times, most recently
from
August 17, 2023 16:54
a190360
to
f50d1d0
Compare
MichalLytek
force-pushed
the
master
branch
4 times, most recently
from
January 11, 2024 07:39
6e1c81e
to
c8d2e2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1297 +/- ##
==========================================
- Coverage 95.50% 95.40% -0.10%
==========================================
Files 113 114 +1
Lines 1847 1873 +26
Branches 364 364
==========================================
+ Hits 1764 1787 +23
- Misses 83 86 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #620 and a part of #200
This PR enhances
@UseMiddleware()
and@Authorized()
, now we can put them directly on the resolver so that we can avoid repeating on each method.Use
@UseMiddleware()
like so:Middlewares will be called in the order of global, resolver, field.
Use
@Authorized()
like so:When you set
roles
for both the field and the resolver, the roles will be overwritten by the field's@Authorized()
I also make a function
createMiddlewareDecorator
to help you create custom middlewares, it is similar tocreateMethodDecorator
, but can be placed on resolver