Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart.js bundle update and hover fix #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2021

PR introduces two changes:

  1. Chart.js bundle was updated to v2.9.4
  2. Functions that changes state of points when we hover mouse pointer above them were uncommented. Currently fixed values were used to set the state of points in such a case.

AD 1) As for the Chart.js update my M.O. was to:

  • open diff between original Chart.bundle.js v2.9.3 and v2.9.4.
  • open diff between customized Chart.js and Chart.bundle.js from v2.9.4 tag.

All changes that were available between original bundles were added, all other were kept as-is (customizations for the QML). Seems to be fine but it would be nice if verified by someone more proficient in JS. :)

AD 2) I suppose the fixed values were used for testing and never uncommented. I haven't seen any side effects of uncommenting those other than fixed behavior of changing point style during hover event.

Attached GIFs presenting behavior for such a point style:

elements: {
    point: {
        pointStyle: 'circle',
        radius: 3,
        borderWidth: 1,
        hoverRadius: 6,
        hoverBorderWidth: 2
    }
}

BEFORE THE CHANGES

before

AFTER THE CHANGES

after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant