DO NOT MERGE: SH7604 and SH, all the fixes for the saturn, backported ( testing/unofficial )

[asturur]

This PR is made by applying blindly the changes to the components available on both the the s32x and the saturn core, but developed for the saturn.
Doing so we fixed one or two issues ( pitfall and xmen )

Saturn work is done without s32x in mind and so this may break things or fix nothing.
Regardless is easy to try, it provides a build for testing to whoever can do so and everyone is welcome to test this build, but there are no expectations.

[asturur]

S32X_20230704.zip

[asturur]

I didn't test the build yet, i will proceed with the usual things, but i won't test the full library of games.
If someone wants to have a look.
I wouldn't merge before extensive testing is done

[asturur]

• Nothing changes in pinocchio UI
• Doom32 resurrection works ok

... i ll do more testing

[a-barone]

• Nothing changes in pinocchio UI
• Doom32 resurrection works ok

... i ll do more testing

I tested several games last night with this build.
Completed MK II, won the Intercontinental Championship in WWF Wrestlemania: The Arcade Game, won races in VR Deluxe, had several fights in VF, played a few stages of Pitfall: TMA, played Star Wars Arcade, played at least 30 minutes of Space Harrier and about 15 minutes of After Burner Completed and D32XR.
No issues were found.
I want to check the performance compared to the real hardware and update that ticket.

[asturur]

Added the recent mult changes
srg320/SH@357ccd8

[Toryalai1]

Added the recent mult changes srg320/SH@357ccd8

Can you please share build with latest changes?

[asturur]

https://github.com/asturur/S32X_MiSTer/releases/download/unstable-builds/S32X_unstable_20230924_215c75.rbf

[asturur]

managed to do one late yesterday exactly to post it here

[asturur]

pinocchio trembling UI still there.

[asturur]

Added
srg320/SH@956bdb8
and
srg320/SH@e5edb8a

[asturur]

as for who wants to try:
https://github.com/asturur/S32X_MiSTer/releases/download/unstable-builds/S32X_unstable_20231004_109be4.rbf

[asturur]

i don't see any meaninful changes in my tests. Pinocchio trembling ui is still there.
The visual artifact is correlated with scrolling changing speed

[asturur]

https://github.com/asturur/S32X_MiSTer/releases/download/unstable-builds/S32X_unstable_20231010_10fda8.rbf

rebased on latest fix.

[mario-64]

https://github.com/asturur/S32X_MiSTer/releases/download/unstable-builds/S32X_unstable_20231010_10fda8.rbf

rebased on latest fix.

Does this include the recent Knuckles Chaotix fix by @YLFAndy ?

[asturur]

yes

[birdybro]

This can probably be closed, there have been further changes to the SH core on the Saturn_MiSTer repo. A new PR could probably be opened after someone tests updating to the latest SH module for regressions.

[asturur]

Leave it open if it doesn't bother you, we got a single update to the sh2 few days ago and i was about to update it

[asturur]

The new sh code is not supposed to also work here, but i just try in case it fixes something. Not sure how much the saturn code is generic/accurate or it serve the purpose of fitting a saturn on a mister. We did solve a bunch of issues tho by just trying

[asturur]

S32X_unstable_20240208_003007.zip

This is the latest commit but i forgot to add the latest main inside

[asturur]

S32X_unstable_20240208_008585.rbf.zip

This has the latest template in

[asturur]

Current official build

Bugs i can reproduce:

• pinocchio flicker ui
• Flickers in spiderman web of fire
• After some hours of running the star wars arcade demo the game hangs

build 2024028

• all the changes so far
• doesn't fix anything in pinocchio
• star wars arcade attrac mode locks up after few minutes ( official is fine )

Will do more testing of the intermediate changes

[asturur]

build 20240217

All the changes up to today.

S32X_unstable_20240216_2392a3.zip

[asturur]

S32X_unstable_20240227_10a9dc.rbf.zip

[asturur]

S32X_unstable_20240229_16608d.rbf.zip

[asturur]

S32X_unstable_20240423_19662c.rbf.zip

Here is the latest build on the latest main / framework

[sorgelig]

If there are no issues, then i suggest to merge this PR

[asturur]

The build of febraury 8 Had some issue that disappeared after the following updates.
I didn't test the last commit yet becuase i have been busy.
The test i do is usually letting doom and starwar arcade and virtua racing run for hours, on top of checking if some known defects ( only pinocchio ) have disappeared

[sorgelig]

No forcing from my side. Take your time for tests.

[asturur]

So this latest combination of commits hangs star wars arcade after 15 minutes or more. something subtle is wrong, and it started happening in febraury.

Definetely is not mergeable.
There could be some commits that are actual corrections ( like the one to some cpu instructions ) but without a failing case fixed isn't really worth it.

We can keep it open or not for visibility and i can still surface or retest a build if a bug surfaces on the official release or if more commits come out.