Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I/O revision II 文本提取补充实现 #3

Open
wants to merge 5 commits into
base: arc_v1
Choose a base branch
from
Open

I/O revision II 文本提取补充实现 #3

wants to merge 5 commits into from

Conversation

ddddyyyy
Copy link

文本的结尾判断并没有加边界检测，会将三个资源文件的一小部分误提取，不过好像影响不大，就不管了

MewX
MewX requested changes Apr 19, 2019
View reviewed changes
Copy link
Owner

@MewX MewX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main函数的改动不用提交，然后主要改动好像全都没提交上来

@ddddyyyy
Copy link
Author

main函数的改动不用提交，然后主要改动好像全都没提交上来

请直接看https://github.com/MewX/cross-channel_chinese-localization_project/pull/3/commits/ca51e633104488cefd4a3618b592203cb366b557
ca51e63这个提交，其他的提交是我手残上传上去的😢

@MewX
Copy link
Owner

MewX commented Aug 20, 2019

一般来说提交pull request直接新建一个branch，然后只做想要merge 的改动在这个branch，自己的改动可以放在其他branch。

我看了下后面的提交，很多临时文件和输入文件都提交进来了，有点messy，没法merge。

你要不要试试新建一个branch，然后 git reset --hard ca51e633104488cefd4a3618b592203cb366b557。如果有其他想要添加进来的就用 git cherrypick 加进这个branch。然后提交一个新的pull request？

如果不想练手的话，我可以直接代劳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MewX MewX MewX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddddyyyy @MewX