Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input debug info #732

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

Kiisu-Master
Copy link
Contributor

No description provided.

@MewPurPur
Copy link
Owner

MewPurPur commented May 14, 2024

Looks good! Some nitpicks:

  • 10 lines is too much, I'd say keep 5 lines at most to give space for other things.
  • Clear the label when it's hidden, don't fill it until it's shown with F3.

var debug_text := input_debug_label.text
var event_text := event.as_text()
if event_text == last_input:
debug_text = debug_text.left(debug_text.left(-1).rfind("\n") + 1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
debug_text = debug_text.left(debug_text.left(-1).rfind("\n") + 1)
debug_text = debug_text.left(debug_text.rfind("\n", -2) + 1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Sorry then

@MewPurPur MewPurPur merged commit f532960 into MewPurPur:main May 15, 2024
2 checks passed
@MewPurPur
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants