feat: dynamic favicon and notice for live updates #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a favicon and a page title which display whether the door is open. They update alongside the rest of the page. This allows the user to see the status of the door by keeping the tab open without having to switch to it.
It also adds a notice that the page refreshes automatically, as currently this fact is not obvious. I added this notice in the JavaScript so that it doesn't display if the user has JavaScript disabled.
The icons can be distinguished both by colour and content so as to be colourblind-friendly. The page doesn't have a favicon while the status is loading.