Fix issue 24464 #24570
Fix issue 24464 #24570
Conversation
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 0 out of 1 committers have signed the CLA. |
|
It seems 60e4dda |
ui/ducks/send/swap-and-send-utils.ts
Outdated
| validator: (error: string | null) => | ||
| error === null || typeof error === 'string', | ||
| type: 'object', | ||
| validator: (error: any) => |
There was a problem hiding this comment.
Let's use unknown here instead
ui/ducks/send/swap-and-send-utils.ts
Outdated
| error === null || typeof error === 'string', | ||
| type: 'object', | ||
| validator: (error: any) => | ||
| error === null || typeof error === 'object', |
There was a problem hiding this comment.
The linter is also complaining about a new line here; there may be a broken setting in your VSCode
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
Signed-off-by: Ethan Wessel <ethan.wessel@consensys.net>
|
It appears if I wait long enough the simulation doesn't fail: |
|
Just for the tracking - it is a bug, simulations fail if send+swap performed for non-native tokens, build on |
Description
Related issues
Fixes: #24464
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist