Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: force update state after snap request #24560

Merged
merged 2 commits into from
May 16, 2024

Conversation

FrederikBolding
Copy link
Member

Description

Adds logic to force update the MetaMask state after requests to Snaps that create interfaces. This reduces the latency of the first viewing of the home page as the state is synced instantly and not debounced.

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label May 16, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 16, 2024 12:53
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3b4aed4]
Page Load Metrics (1451 ± 606 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint742021143718
domContentLoaded105020105
load61320314511261606
domInteractive105020105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 269 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (0ac312c) to head (3b4aed4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24560   +/-   ##
========================================
  Coverage    67.37%   67.37%           
========================================
  Files         1289     1289           
  Lines        50213    50213           
  Branches     13005    13005           
========================================
  Hits         33827    33827           
  Misses       16386    16386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit d193288 into develop May 16, 2024
72 checks passed
@FrederikBolding FrederikBolding deleted the fb/force-update-state-after-snap-request branch May 16, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants