Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump permission-log-controller to ^2.0.1 #24432

Merged
merged 5 commits into from
May 16, 2024

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented May 8, 2024

Description

The primary purpose for upgrading this package is to ensure that we are using a version that relies on @metamask/base-controller v4, which protects the state from being mutated accidentally and includes more type safety for messengers, among other improvements.

See changelog:
https://github.com/MetaMask/core/blob/%40metamask/permission-log-controller%402.0.1/packages/permission-log-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses #24140

Manual testing steps

There should be no functional changes in this PR

Screenshots/Recordings

None

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito added dependencies Pull requests that update a dependency file team-wallet-framework labels May 8, 2024
@mikesposito mikesposito requested a review from a team as a code owner May 8, 2024 12:20
@mikesposito
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@mikesposito mikesposito requested review from a team as code owners May 8, 2024 12:29
Copy link

socket-security bot commented May 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/permission-log-controller@2.0.1 None 0 124 kB metamaskbot

🚮 Removed packages: npm/@metamask/permission-log-controller@1.0.0

View full report↗︎

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (d27a233) to head (1948bbc).
Report is 57 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24432      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1288      +10     
  Lines        49881    50153     +272     
  Branches     12944    13023      +79     
===========================================
+ Hits         33605    33842     +237     
- Misses       16276    16311      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [753a8e4]
Page Load Metrics (1806 ± 694 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701871103517
domContentLoaded96419147
load54360618061445694
domInteractive96419147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.4 KiB (0.38%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [1948bbc]
Page Load Metrics (608 ± 524 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69157912613
domContentLoaded98018178
load5631696081092524
domInteractive98017178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12.4 KiB (0.38%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mikesposito mikesposito merged commit 1a3de5f into develop May 16, 2024
72 checks passed
@mikesposito mikesposito deleted the bump-permission-log-controller branch May 16, 2024 15:13
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants