Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump phishing-controller to ^9.0.2 (v11.16.0 cherry-pick)) #24329

Merged
merged 1 commit into from
May 2, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 1, 2024

Description

This is a cherry-pick of #24311 for v11.16.0

This version of phishing-controller includes the changes to Stalelist update interval to 30 days and the hotlist update interval to 5 mins.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This version of phishing-controller includes the changes to Stalelist
update interval to 30 days and the hotlist update interval to 5 mins.

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented May 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt
Copy link
Member Author

Gudahtt commented May 1, 2024

@metamaskbot update-policies

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 1, 2024
@metamaskbot
Copy link
Collaborator

No policy changes

@Gudahtt Gudahtt marked this pull request as ready for review May 1, 2024 15:25
@Gudahtt Gudahtt requested review from a team as code owners May 1, 2024 15:25
@metamaskbot
Copy link
Collaborator

Builds ready [3e499fd]
Page Load Metrics (412 ± 393 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57135852110
domContentLoaded85720105
load462401412819393
domInteractive85720105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -5.7 KiB (-0.16%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (d181619) to head (3e499fd).

Additional details and impacted files
@@                Coverage Diff                @@
##           Version-v11.16.0   #24329   +/-   ##
=================================================
  Coverage             67.46%   67.46%           
=================================================
  Files                  1263     1263           
  Lines                 49327    49327           
  Branches              12854    12854           
=================================================
  Hits                  33278    33278           
  Misses                16049    16049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm merged commit 2796377 into Version-v11.16.0 May 2, 2024
68 checks passed
@danjm danjm deleted the cherry-pick-phishing-controller-bump branch May 2, 2024 01:05
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label May 2, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.16.0 on PR, as PR was cherry-picked in branch 11.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.0 Issue or pull request that will be included in release 11.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants