-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getMinimumGasTotalInHexWei error when gasEstimateType === "fee_market" #24287
fix: getMinimumGasTotalInHexWei error when gasEstimateType === "fee_market" #24287
Conversation
…arket' Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -253,6 +253,7 @@ export const transactionFeeSelector = function (state, txData) { | |||
} | |||
} else { | |||
switch (gasEstimateType) { | |||
case GasEstimateTypes.feeMarket: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed in this PR, but this is a fundamental public selector with no unit tests, so worth creating a ticket to add some and maybe even refactor the selector for readability at the same time.
Builds ready [510fae4]
Page Load Metrics (193 ± 268 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
See Issue #24263 for investigation details
This will be a hotfix targeting v11.14.3
Related issues
Fixes: #24263
Manual testing steps
One way to repro is by adding the Scroll Sepholia Testnet (see: https://docs.scroll.io/en/user-guide/setup/), then using our test dapp > Send Eth > Send
For other repro methods, please refer to the related issue ticket
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist