Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getMinimumGasTotalInHexWei error when gasEstimateType === "fee_market" #24287

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Apr 29, 2024

Description

See Issue #24263 for investigation details

This will be a hotfix targeting v11.14.3

Related issues

Fixes: #24263

Manual testing steps

One way to repro is by adding the Scroll Sepholia Testnet (see: https://docs.scroll.io/en/user-guide/setup/), then using our test dapp > Send Eth > Send

For other repro methods, please refer to the related issue ticket

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…arket'

Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
@digiwand digiwand requested a review from a team as a code owner April 29, 2024 15:33
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -253,6 +253,7 @@ export const transactionFeeSelector = function (state, txData) {
}
} else {
switch (gasEstimateType) {
case GasEstimateTypes.feeMarket:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed in this PR, but this is a fundamental public selector with no unit tests, so worth creating a ticket to add some and maybe even refactor the selector for readability at the same time.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Apr 29, 2024
@digiwand digiwand merged commit de092fb into develop Apr 29, 2024
70 of 71 checks passed
@digiwand digiwand deleted the fix-confirm-getMinimumGasTotalInHexWei-fee-market branch April 29, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@metamaskbot metamaskbot added the release-11.17.0 Issue or pull request that will be included in release 11.17.0 label Apr 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [510fae4]
Page Load Metrics (193 ± 268 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint55145792210
domContentLoaded86014126
load442627193559268
domInteractive86014126
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -1 Bytes (-0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.17.0 Issue or pull request that will be included in release 11.17.0 team-confirmations Push issues to confirmations team
Projects
None yet
4 participants