New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ♻️ change the way we are handling some metamask noti… #24269
refactor: ♻️ change the way we are handling some metamask noti… #24269
Conversation
…ns controller states
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
Builds ready [17cd9e3]
Page Load Metrics (840 ± 651 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24269 +/- ##
========================================
Coverage 67.28% 67.28%
========================================
Files 1275 1275
Lines 49707 49707
Branches 12916 12916
========================================
Hits 33444 33444
Misses 16263 16263 ☔ View full report in Codecov by Sentry. |
Builds ready [ac704c8]
Page Load Metrics (543 ± 464 ms)
Bundle size diffs
|
Builds ready [ac704c8]
Page Load Metrics (543 ± 464 ms)
Bundle size diffs
|
Description
This PR changes the management of three states handled by the controller to make their definition assertive.
Pre-merge author checklist
Pre-merge reviewer checklist