Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump name-controller to ^6.0.1 #24229

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Apr 24, 2024

Description

There are a few notable changes between 4.2.0 and 6.0.1:

  • Support for fetching proposed nicknames via Etherscan on Optimism Goerli has been removed in favor of Optimism Sepolia
  • Support for fetching proposed nicknames via Etherscan on Linea Sepolia has been added
  • Proposed nicknames now get automatically removed from state after 24 hours

See the changelog for more:

https://github.com/MetaMask/core/blob/%40metamask/name-controller%406.0.1/packages/name-controller/CHANGELOG.md

Open in GitHub Codespaces

Related issues

Progresses #24140.

Manual testing steps

This PR should not introduce any functional changes; the petnames feature should continue to work as designed.

Screenshots/Recordings

(None)

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

There are a few notable changes between 4.2.0 and 6.0.1:

- Support for fetching proposed nicknames via Etherscan on Optimism
  Goerli has been removed in favor of Optimism Sepolia
- Support for fetching proposed nicknames via Etherscan on Linea Sepolia
  has been added
- Proposed nicknames now get automatically removed from state after 24
  hours

See the changelog for more:

<https://github.com/MetaMask/core/blob/%40metamask/name-controller%406.0.1/packages/name-controller/CHANGELOG.md>
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Apr 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/name-controller@6.0.1 network 0 273 kB metamaskbot

🚮 Removed packages: npm/@metamask/name-controller@4.2.0

View full report↗︎

@mikesposito
Copy link
Member

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (d27a233) to head (c6a0119).
Report is 55 commits behind head on develop.

❗ Current head c6a0119 differs from pull request most recent head 6158603. Consider uploading reports for the commit 6158603 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24229      +/-   ##
===========================================
+ Coverage    67.37%   67.48%   +0.11%     
===========================================
  Files         1278     1288      +10     
  Lines        49881    50153     +272     
  Branches     12944    13023      +79     
===========================================
+ Hits         33605    33842     +237     
- Misses       16276    16311      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikesposito mikesposito marked this pull request as ready for review May 8, 2024 10:55
@mikesposito mikesposito requested review from a team as code owners May 8, 2024 10:55
@metamaskbot
Copy link
Collaborator

Builds ready [b2070f0]
Page Load Metrics (1967 ± 752 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint743791286833
domContentLoaded10107252211
load61386619671566752
domInteractive10107252211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 11.33 KiB (0.35%)
  • ui: 0 Bytes (0.00%)
  • common: -872 Bytes (-0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [c6a0119]
Page Load Metrics (977 ± 670 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61155942814
domContentLoaded94915105
load5134929771396670
domInteractive94915105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 11.33 KiB (0.35%)
  • ui: 0 Bytes (0.00%)
  • common: -872 Bytes (-0.01%)

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented May 14, 2024

There is one breaking change in this range that doesn't seem to require any changes to the extension, but I wasn't sure:

  • BREAKING: Add expire limit for proposed names (#3748)
  • Expired names now get removed on every call to updateProposedNames

cc @cryptotavares @OGPoyraz @vinistevam could you confirm that this change is safe to bring in?

Seems like it should be, so I will not block on this, but I wanted to call attention just in case

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OGPoyraz
Copy link
Member

Thanks for the ping @Gudahtt, as you said it's totally safe to merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

None yet

8 participants