New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump name-controller to ^6.0.1 #24229
base: develop
Are you sure you want to change the base?
Conversation
There are a few notable changes between 4.2.0 and 6.0.1: - Support for fetching proposed nicknames via Etherscan on Optimism Goerli has been removed in favor of Optimism Sepolia - Support for fetching proposed nicknames via Etherscan on Linea Sepolia has been added - Proposed nicknames now get automatically removed from state after 24 hours See the changelog for more: <https://github.com/MetaMask/core/blob/%40metamask/name-controller%406.0.1/packages/name-controller/CHANGELOG.md>
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/name-controller@4.2.0 |
@metamaskbot update-policies |
Policies updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24229 +/- ##
===========================================
+ Coverage 67.37% 67.48% +0.11%
===========================================
Files 1278 1288 +10
Lines 49881 50153 +272
Branches 12944 13023 +79
===========================================
+ Hits 33605 33842 +237
- Misses 16276 16311 +35 ☔ View full report in Codecov by Sentry. |
Builds ready [b2070f0]
Page Load Metrics (1967 ± 752 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [c6a0119]
Page Load Metrics (977 ± 670 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is one breaking change in this range that doesn't seem to require any changes to the extension, but I wasn't sure:
cc @cryptotavares @OGPoyraz @vinistevam could you confirm that this change is safe to bring in? Seems like it should be, so I will not block on this, but I wanted to call attention just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the ping @Gudahtt, as you said it's totally safe to merge it in. |
Description
There are a few notable changes between 4.2.0 and 6.0.1:
See the changelog for more:
https://github.com/MetaMask/core/blob/%40metamask/name-controller%406.0.1/packages/name-controller/CHANGELOG.md
Related issues
Progresses #24140.
Manual testing steps
This PR should not introduce any functional changes; the petnames feature should continue to work as designed.
Screenshots/Recordings
(None)
Pre-merge author checklist
Pre-merge reviewer checklist