Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: percentage increase feature #24223

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Apr 24, 2024

Description

This pull request introduces a new feature to the MetaMask extension that enhances user experience by displaying the percentage increase or decrease for each token directly within the UI. This update aims to provide users with immediate visual feedback on the performance of their tokens, helping them make more informed decisions based on recent market trends.

core PR: MetaMask/core#4206

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to the wallet view
  2. You should see the percentage of increase/decrease

Screenshots/Recordings

Before

Screenshot 2024-04-24 at 15 03 39

After

Screenshot 2024-04-24 at 14 53 25

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner April 24, 2024 13:09
@salimtb salimtb added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 24, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the percentage-increase-feature branch 6 times, most recently from 1705047 to d8a6f0b Compare April 24, 2024 14:24
@salimtb salimtb marked this pull request as draft April 24, 2024 15:02
@salimtb salimtb force-pushed the percentage-increase-feature branch 8 times, most recently from ac1c835 to 0c1792c Compare April 25, 2024 22:17
@metamaskbot
Copy link
Collaborator

Builds ready [0e141e0]
Page Load Metrics (842 ± 578 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57162862813
domContentLoaded8331253
load4529508421203578
domInteractive8331253
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.7 KiB (0.06%)
  • common: 95 Bytes (0.00%)

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (d27a233) to head (c1cf600).
Report is 55 commits behind head on develop.

❗ Current head c1cf600 differs from pull request most recent head c2483ae. Consider uploading reports for the commit c2483ae to get more accurate results

Files Patch % Lines
ui/selectors/selectors.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24223      +/-   ##
===========================================
- Coverage    67.37%   67.34%   -0.03%     
===========================================
  Files         1278     1277       -1     
  Lines        49881    49780     -101     
  Branches     12944    12947       +3     
===========================================
- Hits         33605    33523      -82     
+ Misses       16276    16257      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb marked this pull request as ready for review April 26, 2024 14:21
@salimtb salimtb force-pushed the percentage-increase-feature branch from 0e141e0 to cd04145 Compare May 2, 2024 08:06
@salimtb salimtb requested review from legobeat, darkwing and a team May 2, 2024 08:12
@salimtb salimtb force-pushed the percentage-increase-feature branch from cd04145 to c1cf600 Compare May 2, 2024 08:35
@metamaskbot
Copy link
Collaborator

Builds ready [c1cf600]
Page Load Metrics (759 ± 571 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61194983718
domContentLoaded106816136
load4929197591188571
domInteractive106816136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.8 KiB (0.06%)
  • common: 53 Bytes (0.00%)

@salimtb salimtb force-pushed the percentage-increase-feature branch from c1cf600 to 31a6392 Compare May 14, 2024 09:06
@salimtb salimtb requested review from a team as code owners May 14, 2024 09:06
@salimtb salimtb changed the title Percentage increase feature feat: percentage increase feature May 14, 2024
@salimtb salimtb force-pushed the percentage-increase-feature branch from ca90667 to 8d6ebc1 Compare May 14, 2024 10:49
Copy link

socket-security bot commented May 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/cockatiel@3.1.3, npm/fast-xml-parser@4.3.6, npm/jsonschema@1.4.1

View full report↗︎

@salimtb salimtb force-pushed the percentage-increase-feature branch 3 times, most recently from b51afa7 to 2f0bd6f Compare May 14, 2024 12:36
@salimtb salimtb force-pushed the percentage-increase-feature branch from 2f0bd6f to 7cc9b8a Compare May 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants