Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): @solana/web3.js 1.91.6 #24094

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(deps): @solana/web3.js 1.91.6 #24094

merged 1 commit into from
Apr 17, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 17, 2024 •
edited

Description

Fixes CVE-2024-30253 / GHSA-8m45-2rjm-j347 and failing deps-audit CI job.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 17, 2024
@legobeat legobeat changed the title fix(deps): @solana/web3.js 1.91.6d fix(deps): @solana/web3.js 1.91.6 Apr 17, 2024
@legobeat legobeat marked this pull request as ready for review April 17, 2024 22:03
@legobeat legobeat requested a review from a team as a code owner April 17, 2024 22:03
Gudahtt
Gudahtt approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Apr 17, 2024 •
edited

@metamaskbot update-policies

Boo, fork. Hmm

@Gudahtt
Copy link
Member

Gudahtt commented Apr 17, 2024

Oh. No policy changes needed (I tried updating them on this PR that branched from this PR: #24097). I should have looked more closely at the CI failure, it was an CircleCI failure.

rekmarks
rekmarks approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gudahtt Gudahtt merged commit b1cbcfa into MetaMask:develop Apr 17, 2024
84 of 89 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@legobeat legobeat deleted the deps-solana-web3 branch April 18, 2024 02:06
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 25, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.16.0 on PR, as PR was added to branch 11.16.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-extension-platform team-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legobeat @Gudahtt @metamaskbot @rekmarks