Added QR code #23428

albertolive · 2024-03-12T14:56:41Z

Description

Develop and implement a QR code-based system to enable secure and efficient connections between custodian accounts and the web extension, leveraging advanced encryption methods and API communication.

https://www.loom.com/share/5968d1ab02894f88a1b4155cd1c55fe1?sid=58fc6793-4a82-4e79-b2ab-6bd81377d5df

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-12T14:56:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-03-13T08:37:56Z

Builds ready [36ec5f6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1056 ± 406 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	252	147	49	23
		domContentLoaded	10	117	39	31	15
		load	64	2071	1056	846	406
		domInteractive	10	117	39	31	15

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

ui/pages/institutional/custody/custody.js

ui/components/institutional/qr-code-modal/qr-code-modal.js

# Conflicts: # ui/pages/institutional/custody/custody.js

…sk-extension into MMI-4693-QR-code

albertolive · 2024-04-17T12:46:34Z

@metamaskbot update-policies

metamaskbot · 2024-04-17T12:56:31Z

Policies updated

# Conflicts: # package.json # yarn.lock

socket-security · 2024-04-18T12:32:38Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask-institutional/transaction-update@0.1.38

View full report↗︎

socket-security · 2024-04-18T12:32:41Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

DDDDDanica · 2024-04-30T09:30:29Z

ui/components/institutional/qr-code-modal/qr-code-modal.js

+    onClose();
+  }, [dispatch, mmiActions, onClose]);
+
+  const handleError = useCallback((message, e) => {


Could extract this as a util function. wdyt?

I think that in this case it doesn't provide any benefit as it's only being used inside this component and it's just for MMI context.

DDDDDanica · 2024-04-30T09:31:01Z

ui/components/institutional/qr-code-modal/qr-code-modal.js

+        setQrConnectionRequest(decryptedMessage);
+        handleClose();
+      } catch (e) {
+        handleError('An error occurred while updating connection requests.', e);


Can you test this error handling as well?

To test the error handling inside the catch block when updating connection requests in the component, I need to simulate a scenario where setQrConnectionRequest fails. I don't think this will benefit us. Wdyt?

The reason behind this one was i saw you have tests covering all other error catching scenario, if it is covered somewhere else we can leave this as an exception 🙏🏻

metamaskbot · 2024-05-02T09:55:12Z

Builds ready [2e65fbe]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1229 ± 686 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	149	95	24	11
		domContentLoaded	9	49	15	9	4
		load	56	3423	1229	1429	686
		domInteractive	9	49	14	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 181 Bytes (0.00%)

metamaskbot · 2024-05-02T13:36:56Z

Builds ready [87761a1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1384 ± 712 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	161	96	26	12
		domContentLoaded	10	30	14	6	3
		load	55	3893	1384	1484	712
		domInteractive	10	30	14	6	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 181 Bytes (0.00%)

Added QR code

6fb6df3

albertolive added the team-mmi PRs from the MMI team label Mar 12, 2024

Improved code

36ec5f6

shane-t reviewed Mar 13, 2024

View reviewed changes

ui/pages/institutional/custody/custody.js Outdated Show resolved Hide resolved

zone-live reviewed Mar 14, 2024

View reviewed changes

ui/components/institutional/qr-code-modal/qr-code-modal.js Outdated Show resolved Hide resolved

albertolive added 15 commits March 15, 2024 13:17

Clean stuff

355e5e0

initial handshake work

e4e8966

Merge branch 'develop' into MMI-4693-QR-code

8cd8b94

# Conflicts: # ui/pages/institutional/custody/custody.js

Merge branch 'develop' into MMI-4693-QR-code

6259201

Improved code

73a32e3

Merge branch 'develop' into MMI-4693-QR-code

c925859

Improving code

7a8356a

Merge branch 'develop' into MMI-4693-QR-code

5318444

Continue working on it

abd835a

Merge branch 'MMI-4693-QR-code' of https://github.com/MetaMask/metama…

14184b2

…sk-extension into MMI-4693-QR-code

Added logic to decrypt the connect request

b81d203

Merge branch 'develop' into MMI-4693-QR-code

c271122

Merge branch 'develop' into MMI-4693-QR-code

c0a55f9

updated packages, lavamoat and qr code modal

244f554

Merge branch 'develop' into MMI-4693-QR-code

53513b4

Update LavaMoat policies

8793db8

albertolive added 2 commits April 18, 2024 14:29

improved qr modal component

e3ae6de

Merge branch 'develop' into MMI-4693-QR-code

4e55314

# Conflicts: # package.json # yarn.lock

Improved qr code modal

bccb5dc

DDDDDanica reviewed Apr 30, 2024

View reviewed changes

albertolive added 9 commits April 30, 2024 18:46

updated to tsx

0b42348

move to tsx

5e113ab

fix tsx

3ff89a2

fixed tsx

2124074

fix lint

5f9e120

Merge branch 'develop' into MMI-4693-QR-code

3703a12

lint issues

546abb6

fix lint

a4afe1b

fix lint

2e65fbe

albertolive requested a review from DDDDDanica May 2, 2024 08:43

zone-live added 10 commits May 2, 2024 11:18

test

5eff79d

test 2

22b5e3a

clean up

74e41d2

test 3

38a9719

clean up test changes

d63ae12

test logging element

5b29830

test logging env var

014d577

clean up

9e19a21

clean up

8ecc17f

updates visual snapshots

87761a1

DDDDDanica approved these changes May 2, 2024

View reviewed changes

zone-live approved these changes May 2, 2024

View reviewed changes

albertolive merged commit 8d4e334 into develop May 2, 2024
70 of 71 checks passed

albertolive deleted the MMI-4693-QR-code branch May 2, 2024 14:14

github-actions bot locked and limited conversation to collaborators May 2, 2024

metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added QR code #23428

Added QR code #23428

albertolive commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024

metamaskbot commented Mar 13, 2024

albertolive commented Apr 17, 2024

metamaskbot commented Apr 17, 2024

socket-security bot commented Apr 18, 2024 •

edited

socket-security bot commented Apr 18, 2024 •

edited

DDDDDanica Apr 30, 2024

albertolive Apr 30, 2024

DDDDDanica Apr 30, 2024 •

edited

albertolive Apr 30, 2024

DDDDDanica Apr 30, 2024

metamaskbot commented May 2, 2024

metamaskbot commented May 2, 2024

Added QR code #23428

Added QR code #23428

Conversation

albertolive commented Mar 12, 2024 • edited

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 12, 2024

metamaskbot commented Mar 13, 2024

albertolive commented Apr 17, 2024

metamaskbot commented Apr 17, 2024

socket-security bot commented Apr 18, 2024 • edited

socket-security bot commented Apr 18, 2024 • edited

DDDDDanica Apr 30, 2024

Choose a reason for hiding this comment

albertolive Apr 30, 2024

Choose a reason for hiding this comment

DDDDDanica Apr 30, 2024 • edited

Choose a reason for hiding this comment

albertolive Apr 30, 2024

Choose a reason for hiding this comment

DDDDDanica Apr 30, 2024

Choose a reason for hiding this comment

metamaskbot commented May 2, 2024

metamaskbot commented May 2, 2024

albertolive commented Mar 12, 2024 •

edited

socket-security bot commented Apr 18, 2024 •

edited

socket-security bot commented Apr 18, 2024 •

edited

DDDDDanica Apr 30, 2024 •

edited