-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix create-lavamoat-viz script #22759
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7d459b4
to
c9f9750
Compare
c9f9750
to
4eae78a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22759 +/- ##
===========================================
- Coverage 68.44% 68.43% -0.00%
===========================================
Files 1141 1141
Lines 43766 43766
Branches 11726 11726
===========================================
- Hits 29952 29951 -1
- Misses 13814 13815 +1 ☔ View full report in Codecov by Sentry. |
48d70a7
to
96366b0
Compare
b49fa5b
to
fcb8025
Compare
f600be3
to
e9738d3
Compare
a8cf27f
to
2a8df84
Compare
2a8df84
to
ba49a17
Compare
ba49a17
to
0abbea0
Compare
…quentially to avoid OoM
…owsers-medium on node-browsers-small, we get spurious exit code 137
8b9fd31
to
8e30e32
Compare
@@ -10,8 +10,33 @@ BUILD_DEST="./build-artifacts/build-viz/" | |||
# prepare artifacts dir | |||
mkdir -p "${BUILD_DEST}" | |||
|
|||
# generate lavamoat debug config | |||
# generate lavamoat debug configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
policies
# generate lavamoat debug configs | |
# generate lavamoat debug policies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprised to see the policy changes but otherwise good
No release label on PR. Adding release label release-11.16.0 on PR, as PR was added to branch 11.16.0 when release was cut. |
Description
It seems like the
lavamoat-viz
usage in CI has been broken since #12702. Thecreate-lavamoat-viz
script is silently failing ondevelop
:Changes
npx
(undeterministic) and call thedevDependency
oflavamoat-viz
lavamoat:debug:webapp
package scripts which is tolavamoat:debug:build
whatlavamoat:webapp:auto
is tolavamoat:build:auto
(that is, it produces LavaMoatpolicy-debug.json
files alongside the browserify policy for each build type).gitignore
to avoid this increasing contribution overhead.lavamoat-viz
to correctly generate forbuild-system
Related issues
job-publish-prerelease
#23704Manual testing steps
yarn build:dev dist
.circleci/scripts/create-lavamoat-viz.sh
--parallel=false
option toyarn lavamoat:debug:webapp
build-artifacts/build-viz/index.html
in web browserScreenshots/Recordings
Before
N/A
After
Firefox (
build-system
)Chrome (
flask
)Pre-merge author checklist
Pre-merge reviewer checklist