Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to transaction-controller 28.1.1 to fix NFT mint simulation #24306

Merged
merged 4 commits into from Apr 30, 2024
Merged

fix: update to transaction-controller 28.1.1 to fix NFT mint simulation #24306

merged 4 commits into from Apr 30, 2024

Conversation

dbrans
Copy link
Contributor

@dbrans dbrans commented Apr 30, 2024 •
edited

Description

Update transaction-controller core package to bring in this fix to NFT mint simulation: MetaMask/core#4217

Open in GitHub Codespaces

Related issues

Fixes: #24251

Manual testing steps

  1. Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h
  2. Try minting the nft
  3. Simulation should work and show the nft in the "You receive" section.

Screenshots/Recordings

Before

(Simulation Failed message)

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans added the team-transactions Transactions team label Apr 30, 2024
@dbrans dbrans marked this pull request as ready for review April 30, 2024 12:23
@dbrans dbrans requested a review from a team as a code owner April 30, 2024 12:23
@dbrans
Copy link
Contributor Author

dbrans commented Apr 30, 2024

I verified the fix manually by following the manual steps in the description.

antonydenyer
antonydenyer previously approved these changes Apr 30, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 previously approved these changes Apr 30, 2024
View reviewed changes
@dbrans dbrans dismissed stale reviews from matthewwalsh0 and antonydenyer via 488c2ad April 30, 2024 13:06
@metamaskbot
Copy link
Collaborator

Builds ready [df04798]
Page Load Metrics (1621 ± 685 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint561711033617
domContentLoaded86620178
load45375116211428685
domInteractive86620178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 571 Bytes (0.01%)

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (8a0e455) to head (df04798).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24306   +/-   ##
========================================
  Coverage    67.28%   67.28%           
========================================
  Files         1275     1275           
  Lines        49707    49707           
  Branches     12916    12916           
========================================
  Hits         33444    33444           
  Misses       16263    16263

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbrans dbrans merged commit 9c50ce2 into develop Apr 30, 2024
71 checks passed
@dbrans dbrans deleted the dbrans/update-transaction-controller branch April 30, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
@metamaskbot metamaskbot added the release-11.17.0 Issue or pull request that will be included in release 11.17.0 label Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonydenyer antonydenyer antonydenyer approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees
No one assigned
Labels
release-11.17.0 Issue or pull request that will be included in release 11.17.0 team-transactions Transactions team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Simulations should handle minting NFTs
4 participants
@dbrans @metamaskbot @antonydenyer @matthewwalsh0