Add some automation to All_Forall for proving via nth_error
#833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
coq-8.16+all-forall-utils
branch
2 times, most recently
from
338093d
to
d68a961
Compare
|
Indeed, that's a more general approach and it would be great to have this! |
|
Unfortunately, this seems to result in a bunch of universe errors down the line, and I ran out of time trying to debug them :-/ |
JasonGross
force-pushed
the
coq-8.16+all-forall-utils
branch
2 times, most recently
from
a55ff91
to
2d25a7a
Compare
The existing strategy of combining `Forall`s in the context and then trying to prove the property universally is lossy when there are goals like `Forall (Forall2 P l1) l2` lying around, because it doesn't guarantee that all relevant hypotheses are found. Instead, we can convert all hypotheses to `nth_error` and try to carefully specialize hypotheses so that `nth_error`s line up.
JasonGross
force-pushed
the
coq-8.16+all-forall-utils
branch
from
2d25a7a
to
bacf7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got fed up trying to manually prove some weakening properties across checker configuration, and wanted a stronger hammer for dealing with things like
AllandForall.The existing strategy of combining
Foralls in the context and then trying to prove the property universally is lossy when there are goals likeForall (Forall2 P l1) l2lying around, because it doesn't guarantee that all relevant hypotheses are found. Instead, we can convert all hypotheses tonth_errorand try to carefully specialize hypotheses so thatnth_errors line up.