Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce nuget dependencies #1812

Conversation

thompson-tomo
Copy link
Contributor

Closes #1811

@thompson-tomo thompson-tomo marked this pull request as draft May 6, 2024 22:43
@AArnott AArnott changed the title #1811 tweak dependencies. tweak dependencies May 6, 2024
@AArnott
Copy link
Collaborator

AArnott commented May 6, 2024

Please don't put the issue # in the PR title. That just puts two numbers very close to each other and creates confusion.

@thompson-tomo thompson-tomo marked this pull request as ready for review May 7, 2024 21:54
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
@thompson-tomo thompson-tomo force-pushed the chore/#1811_optimiseDependencies branch from 2bf9a5c to 775a966 Compare May 12, 2024 04:47
@AArnott AArnott added this to the v2.5 milestone May 13, 2024
@AArnott AArnott changed the title tweak dependencies Reduce nuget dependencies May 13, 2024
@AArnott AArnott merged commit db2320b into MessagePack-CSharp:master May 13, 2024
5 of 6 checks passed
@thompson-tomo thompson-tomo deleted the chore/#1811_optimiseDependencies branch May 13, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency review to enable optimisations.
2 participants