Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unabling project reloading after project sync in home/projects page #3401

Merged
merged 1 commit into from May 3, 2024
Merged

Unabling project reloading after project sync in home/projects page #3401

merged 1 commit into from May 3, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Apr 30, 2024 •
edited

When syncing from the Home/Projects page, the project does not open automatically after the synchronization is completed.

Fixes #3358

@VitorVieiraZ VitorVieiraZ linked an issue May 2, 2024 that may be closed by this pull request
Synchronizing upstream change opens the project #3358
Closed
@VitorVieiraZ VitorVieiraZ changed the title WIP - unabling project reloading after project sync Unabling project reloading after project sync May 2, 2024
@VitorVieiraZ VitorVieiraZ changed the title Unabling project reloading after project sync Unabling project reloading after project sync in home/project page May 2, 2024
@VitorVieiraZ VitorVieiraZ changed the title Unabling project reloading after project sync in home/project page Unabling project reloading after project sync in home/projects page May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Pull Request Test Coverage Report for Build 8925934410

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 60.061%
Files with Coverage Reduction New Missed Lines %
input/app/projectsmodel.cpp 1 69.17%
Totals Coverage Status
Change from base Build 8925078861: 0.0%
Covered Lines: 7659
Relevant Lines: 12752
💛 - Coveralls

tomasMizera
tomasMizera approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good 👍🏻

@tomasMizera tomasMizera merged commit 2d73ed0 into master May 3, 2024
11 checks passed
@tomasMizera tomasMizera deleted the iss3358 branch May 3, 2024 07:16
@tomasMizera tomasMizera mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synchronizing upstream change opens the project
2 participants
@VitorVieiraZ @tomasMizera