Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter279k
Copy link

Changed log

  • Since the php-5.x versions are inactive for about long time.
    Using the php-7.x versions is fine.
  • Letting the build/ folder be under .gitignore file because this file is generated by PHPUnit.
  • Using the PHPUnit\Framework\TestCase namespace to be compatible with future PHPUnit versions.
  • The PHPUnit fixtures are about setUp and tearDown methods are protected.
  • Using assertCount to assert expected length is same as result count.
  • Using the assertInternalType to assert expected is array type.
  • The --dev option is deprecated when executing composer install command.
    The deprecated warning message is as follows:
You are using the deprecated option "dev". Dev packages are installed by default now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant