Added nl-NL translations. #132
Conversation
|
@rbrouwer Thank you for the contribution. However, Google Assistant SDK doesn't seem to support this language code as of now. Thus, if you try asking a query to the assistant (after fixing the JSON syntax error) with language set to this one, it will throw the following error (in DevTools):
NOTE: For future reference (in case Google adds support for this language in Assistant SDK): |
|
I will talk Dutch to it anyway. Google is smart enough to understand that anyway (really!) and it will also talk back in Dutch. Doing that will however change the app in part Dutch and part the setup language. That's why thought adding those translations would help. Possibly the "GUI" language and "SDK" language should be kept separate? That could possibly be done by adding an SDK language setting in this json structure. I've fixed this json issue just in case. |
|
I've separated "GUI language" and "Assistant/SDK language", allowing people to have those few translated lines in 1 language, while "communicating with Assistant" in another. In case of nl-NL that actually works as you would expect it to work; there might be more languages which will act the same way, but that's for other developers to try out and add. |
|
@rbrouwer That is doable but currently I will leave this PR on hold and get back to it once a proper way of internationalization for the entire UI is figured out. |
@Melvin-Abraham I feel like this list maybe somewhat incomplete. I am 100% sure that the Google Assistant supports Polish officially. (There's even official homepage for it). Yet it's not on the list. |
|
@yahoo1999 , Polish is one of those languages like Dutch. It's not "supported" by the SDK/in that list, but when the language is enabled in your account and you just speak that language to Google Assistant, it will just respond in that same language. I believe there are a few more languages like that! Norwegian also exists for that page and is not in the SDK list. Melvin-Abraham however does not know how he really wants to handle I18n, so I guess we just have to wait until that is decided. |
No description provided.