fix: Update to jdk21 - EXO-71474 - Meeds-io/MIPs#91 #880
Conversation
rdenarie
force-pushed
the
fix/task-71522
branch
2 times, most recently
from
0350693
to
daa7e8c
Compare
rdenarie
changed the title
Before this fix, the simpleDateFormat for locale en is MM/dd/yyyy, HH:mm:ss a In jdk17 and under, the space between 'ss' and 'a' is a simple space In JDK 21, the space was changed to '[NNBSP]a' ([OpenJDK information](https://bugs.openjdk.org/browse/JDK-8324665)) : , so the .contains(" a") returns always false This commit add the test on '[NNBSP]a' in addition of ' a' in order to make it work on both jdk version It also add surefire configuration to work with jdk21 Resolves Meeds-io/MIPs#91
rdenarie
changed the title
|
| <plugin> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <argLine>@{argLine} ${env.MAVEN_OPTS} --add-opens=java.base/jdk.internal.vm=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED</argLine> |
There was a problem hiding this comment.
May be to add here https://github.com/Meeds-io/maven-parent-pom/blob/38f428610ced8e1824eb72d9dd35c5635b771fc8/pom.xml#L768 WDYT ?
There was a problem hiding this comment.
We may need to add those options here as well (for runtime):
https://github.com/Meeds-io/meeds/blob/88622dd72c45a772a792311350c15c606cb0c09d/packaging/plf-tomcat-resources/src/main/resources/bin/setenv.sh#L293
( for windows here https://github.com/Meeds-io/meeds/blob/88622dd72c45a772a792311350c15c606cb0c09d/packaging/plf-tomcat-resources/src/main/resources/bin/setenv.bat#L199 )
Before this fix, the simpleDateFormat for locale en is MM/dd/yyyy, HH:mm:ss a
In jdk17 and under, the space between 'ss' and 'a' is a simple space In JDK 21, the space was changed to '[NNBSP]a' (OpenJDK information) : , so the .contains(" a") returns always false
This commit add the test on '[NNBSP]a' in addition of ' a' in order to make it work on both jdk version
Resolves Meeds-io/MIPs#91