Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix access to site navigation having deleted pages - MEED-6510 - Meeds-io/meeds#1921 #877

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

boubaker
Copy link
Member

Prior to this change, when the administration has the node navigation which references a non existing page, then the administration link isn't displayed and an NPE is thrown. This change will ensure to not consider the navigations which doesn't have an accessible page in the list of available navigation nodes of user.

…eeds-io/meeds#1921

Prior to this change, when the administration has the node navigation which references a non existing page, then the administration link isn't displayed and an NPE is thrown. This change will ensure to not consider the navigations which doesn't have an accessible page in the list of available navigation nodes of user.
@boubaker boubaker requested a review from AzmiTouil April 29, 2024 07:30
@boubaker boubaker enabled auto-merge (squash) April 29, 2024 07:34
Copy link

sonarcloud bot commented Apr 29, 2024

@boubaker boubaker merged commit fc22e82 into develop Apr 29, 2024
5 checks passed
@boubaker boubaker deleted the meed-1921 branch April 29, 2024 07:52
exo-swf pushed a commit that referenced this pull request Apr 29, 2024
…eeds-io/meeds#1921 (#877)

Prior to this change, when the administration has the node navigation
which references a non existing page, then the administration link isn't
displayed and an NPE is thrown. This change will ensure to not consider
the navigations which doesn't have an accessible page in the list of
available navigation nodes of user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants