Meed Layout Editor - Meeds-io/MIPs#120 #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when a node page references itself as root node, a StackOverflow Error is observed while copying node.
Prior to this change, after instanciating a , when getting data, an NPE can be thrown. This change will avoid NPE when getting basic data from a DTO.
…AFT Nav visibility - MEED-3411 - Meeds-io/MIPs#120 (#846) Prior to this change, when requesting multiple pages at the same time from portal, the same page is displayed in all requested pages. This change will move the selection of current site and page into a contextual object `PortalRequestContext` that is built for each HTTP Request, instead to add it in a statefull mode inside the same `WebUI` Component which is shared between all pages. In addition, this change will allow to request a single application inside a page to be displayed in a standalone way (whithout having to use the `StandaloneAppRequestHandler` and `UIStandaloneApplication` which duplicates the code and makes it unmaintainable and not tested continuously).
…#864) Prior to this change, when requesting a portlet using direct access URL to retrieve a resource, the Portlet instance isn't found due to the usage of a randomly generated identifier for Portlet regenerated on each instanciation. This change will ensure the use the storage identifier for a WebUI portlet to ensure coherence of Request queries and expected responses.
…-4975 - Meeds-io/MIPs#120 (#865) This change will move the mapping of `cssClass` and `borderColor` to be used on application as well as on containers.
…D-3875 - Meeds-io/MIPs#120 (#872) This change will allow to: - Retrieve portlet with a designated mode using `maximizedPortletMode` Request Parameter - Return default skin when no selected skin in currently displayed site - Avoid reloading the whole page when using WebUI ajax query - include supported portlet modes in Application Registry DTO
…ds-io/MIPs#120 (#873) This change will allow to define pages layout using sections, cells and columns. At the same time a new XSD has been defined with a cleaned useless entities.
This change will move the 'hidden' class to parent element of portlet instead of the child element to ensure to not have grid gap applied when the application is added in a dynamic of fixed section.
Prior to this change, when the 'targetUserNode = targetUserNode.getParent()' returns null, the targetUserNode is getting null, thus an NPE can be thrown and the site get inaccessible. This change ensures to avoid such an exception and returns the original nodePath.
|
AzmiTouil
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#120