Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SAML] Some properties cannot be modified by configuration - EXO-70965 #866

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

rdenarie
Copy link
Member

Before this fix, property gatein.sso.saml.config.file is not taken in account, the value used was always ${exo.conf.dir}/saml2/picketlink-sp.xml This is due to a default value in context.xml, which not use the property This fix modifies this file to correctly use the property

Resolves Meeds-io/meeds#1856

…-70965

Before this fix, property gatein.sso.saml.config.file is not taken in account, the value used was always ${exo.conf.dir}/saml2/picketlink-sp.xml
This is due to a default value in context.xml, which not use the property
This fix modifies this file to correctly use the property

Resolves Meeds-io/meeds#1856
@rdenarie rdenarie requested a review from azayati April 10, 2024 13:23
@rdenarie rdenarie enabled auto-merge (rebase) April 10, 2024 13:23
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdenarie rdenarie merged commit b1b870a into feature/maintenance Apr 10, 2024
6 checks passed
@rdenarie rdenarie deleted the fix/task-70965 branch April 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
2 participants