fix: Unsearchable disabled users by their email or name - EXO-69348 - Meeds-io/meeds#1827 . #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhanfir
changed the title
rdenarie
previously requested changes
Apr 2, 2024
exo-swf
force-pushed
the
feature/maintenance
branch
from
12dbbb6
to
5d0d915
Compare
exo-swf
force-pushed
the
feature/maintenance
branch
from
b1b870a
to
96d4e11
Compare
akhanfir
force-pushed
the
TASK-69348
branch
2 times, most recently
from
3d5b2bc
to
abe47f2
Compare
…eeds-io/meeds#1827 . Before this change, when set user as a disabled user, select disabled filter and search for usera by his name or his email, user isn't displayed in the result list. To fix this problem, first apply the search by email and then change in the search query the conditions apply in the WHERE line, they are based on the fields email and username must be both like the search term but with this change will be based on one of the two fields either being like this term and this change will only be applied if the search done by the keyword and the user status is disabled. After this change, user is displayed in the result list.
|
mkrout
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when set user as a disabled user, select disabled filter and search for usera by his name or his email, user isn't displayed in the result list. To fix this problem, first apply the search by email and then change in the search query the conditions apply in the
WHEREline, they are based on the fields email and username must be both like the search term but with this change will be based on one of the two fields either being like this term and this change will only be applied if the search done by the keyword and the user status is disabled.After this change, user is displayed in the result list.