Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change default Mail Sender for Notification - MEED-2011 - Meeds-io/meeds#862 #563

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

boubaker
Copy link
Member

Prior to this change, the mail sender name and email was using legacy names. This change will improve it to make the Email Name retrieved from BrandingService (General Settings UI) when not explicitly set. At the same time, this change will set a new default notifications sender email instead of legacy.

@boubaker boubaker requested a review from AzmiTouil March 30, 2023 13:40
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@boubaker boubaker merged commit 4df3476 into develop Mar 30, 2023
3 checks passed
@boubaker boubaker deleted the meed-2011-develop branch March 30, 2023 14:21
exo-swf pushed a commit that referenced this pull request Mar 30, 2023
…-io/meeds#862 (#563)

Prior to this change, the mail sender name and email was using legacy
names. This change will improve it to make the Email Name retrieved from
`BrandingService` (General Settings UI) when not explicitly set. At the
same time, this change will set a new default notifications sender email
instead of legacy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants