Blacken changed function #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the same time install location compatibility is checked.
Functional tests for conflict install locations are removed in favor of the unittest which handle more cases.
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
The use of the function is also emphasized.
Effectively user-site also need write permission checking.
Makes it easier to review and allows for more directed review comments.
Probably, I think you can uncheck that (or ask me to do it) if necessary though. As this has been applied to the original PR as 669f2e8, I'll go ahead and close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to review and allows for more directed review comments.
I can't seem to be able to push to pypa#7828 directly. Did you uncheck the "allow edits from maintainers" checkbox on the PR?