Move some test data generation to main CMakeLists.txt (/ fix fuzzing build failures) #9122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhorstmann-arm
requested review from
tom-cosgrove-arm
and removed request for
tom-cosgrove-arm
Move the generation of tests/src/test_certs.h and tests/src/test_keys.h to the main CMakeLists.txt. This is required because these files are needed both by tests and programs, whereas tests/CMakeLists.txt is only included when ENABLE_TESTING is on. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
force-pushed
the
fix-fuzzing-build-failures
branch
from
47b0af9
to
1238b37
Compare
davidhorstmann-arm
changed the title
Check that we can build under CMake with ENABLE_TESTING=OFF but ENABLE_PROGRAMS=ON. Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
added
needs-review
4 tasks
tom-daubney-arm
removed
the
needs-reviewer
We are testing that we don't break OSS-Fuzz, primarily. Signed-off-by: David Horstmann <david.horstmann@arm.com>
tom-daubney-arm
approved these changes
May 10, 2024
tom-daubney-arm
added
bug
approved
|
Question: Does this need a ChangeLog? It is somewhat user-facing, so I suppose it probably does? |
Oopsie. I would say so yeah. It is a bug fix right? |
Yep that's right! I'll add a ChangeLog |
|
Oh hang on, it was never released! So we don't need a ChangeLog after all :) |
Huzzah! |
tom-cosgrove-arm
added
needs-backports
|
Marking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a fuzzing build failure.
Move test data file generation to the main CMakeLists.txt and perform it whenever either
ENABLE_TESTINGorENABLE_PROGRAMSis on.PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")