Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl_client2: Add Host to HTTP GET request #9118

Open
wants to merge 1 commit into
base: mbedtls-3.6
Choose a base branch
from
Open

ssl_client2: Add Host to HTTP GET request #9118

wants to merge 1 commit into from
+2 −2

Conversation

jetm
Copy link

@jetm jetm commented May 8, 2024

Description

If an IP address shares multiple domain names with different SSL certificates and makes a GET request without the remote server name (host), it will fail with a 421 Misdirect Request.

Please read #9093 for more details on how to reproduce the problem that this PR is addressing and further details.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided. Not required. Please let me know if it's required to update the changelog.
  • 3.6 backport.
  • 2.28 backport. N/A
  • tests provided. Waiting on CI results

Notes for the submitter

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@jetm
ssl_client2: Add Host to HTTP GET request
7a312d7 
If an IP address shares multiple domain names with different SSL
certificates and makes a GET request without the remote server name
(host), it will fail with a 421 Misdirect Request.

Signed-off-by: Javier Tia <javier.tia@linaro.org>
@jetm jetm mentioned this pull request May 8, 2024
Open
10 tasks
@gowthamsk-arm gowthamsk-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests size-xs Estimated task size: extra small (a few hours at most) component-tls and removed needs-ci Needs to pass CI tests labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component-tls needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jetm @gowthamsk-arm