Make TLS 1.2 components work with PSA_CRYPTO_CONFIG set #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace relevant Mbed TLS API config options with their PSA API equivalents. Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
tom-daubney-arm
added
needs-work
size-s
Replace relevant Mbed TLS API config options with their PSA API equivalents. Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
…se_psa Replace relevant Mbed TLS API config options with their PSA API equivalents. Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
tom-daubney-arm
added
needs-review
ronald-cron-arm
requested changes
Apr 29, 2024
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
ronald-cron-arm
requested changes
May 6, 2024
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
ronald-cron-arm
requested changes
May 14, 2024
There was a problem hiding this comment.
Thanks for addressing my comments. The adaption of the configurations seems okay to me now. But there is one thing I did not think about before: remove the non use_psa() equivalent components (i.e component_test_tls1_2_default_stream_cipher_only(), component_test_tls1_2_default_cbc_legacy_cipher_only() and component_test_tls1_2_default_cbc_legacy_cbc_etm_cipher_only()) and then remove the use_psa() suffix of the ones we keep.
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
ronald-cron-arm
requested changes
May 14, 2024
ronald-cron-arm
requested changes
May 16, 2024
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
tom-daubney-arm
force-pushed
the
crypto_config-tls1_2_default_stream_cipher_only_use_psa
branch
from
9cfda24
to
a8004f2
Compare
|
@ronald-cron-arm Apologies for the force push. I had to amend a commit where I had made an error. |
tom-daubney-arm
removed
the
needs-reviewer
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progresses #8153.
Replace Mbed TLS API config options with their PSA API equivalents in three TLS 1.2 components in
all.sh.This PR modifies the following three components:
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: