Matterwiki 0.3.0 #152
Draft
Matterwiki 0.3.0 #152
+43,151
−13,839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's too much to describe here. I'll try my best to describe what's going on:
* Moves server stuff into src/server
* Makes migration and seed script stuff into a CLI task than mucking it up with code
* New directory structure for the server:
.
├── app.js
├── index.js
├── middleware
│ ├── bodyParser.js
│ ├── checkAuth.js
│ └── checkRole.js
├── models
│ ├── archive.js
│ ├── article.js
│ ├── topic.js
│ └── user.js
├── routes
│ ├── articles.js
│ ├── auth.js
│ ├── setup.js
│ └── topics.js
└── utils
├── WDSStarter.js
├── buildDbModel.js
├── config.js
├── constants.js
└── db.js
* Each file in routes could be its own thing, cos each of those make their own sub-routers
* app.js handles app-specific stuff
* index.js handles bootstrapping the server, webpack-dev-server and config management
* Adds new way to handle config via a `config.env` file, which is used for DB and other credentials
* We support ONLY MySQL as of now, which means Bye bye SQLITE!
TODO:
* Add config.env to gitignore
* Finish up the Admin specific stuff
* Update README
* Comments in the code, among other things
* Some error handling for config.js * src/server => src/api
Upgrading to React Router V4
* Adds ESLint, prettier and related plugins for improving code quality * Sets up ESLint + prettier as a pre-commit hook * Runs some prettier format tests * Fix ESLint errors in the code
…jest 🎉 Most of the stuff that's been done is in testHelpers/ of the api. There is some config for running a minimal jest setup in the root, as jest.config.js. Changelog: * Add testing rig, write tests for auth middleware and topicRouter * Add tests for userRouter * Setup modelHolders that can be used to share common stuff like tokens * Add tests for setupRouter * Add tests for the authRouter * Add tests for topicsRouter * Add global setup and teardown fns inside the individual test suites (because of jestjs/jest#1852 (comment)) * Make randomly named DBs for every suite so tests can be run in parallel
The `commit-msg` hook is not entirely gone, its still usable via `npm run cm`
|
good can we make a release ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Matterwiki/Matterwiki/projects/3