Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bark when a rule in Builtin.rules cannot be loaded #1006

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Feb 9, 2024

This is related to #1000. There are some rules included in the Builtin.rules property that cannot be loaded. With this PR, it this happens, a warning is printed. In any case, the idea is to fix these cases before merging this PR.

@mmatera
Copy link
Contributor Author

mmatera commented Feb 9, 2024

These are the rules that cannot be loaded and must be fixed:

  • System`Set[System`Pattern[System`lhs, System`Blank[]], System`Pattern[System`rhs, System`Blank[]]] could not be associated to System`$TimeZone

  • System`Set[System`Pattern[System`lhs, System`Blank[]], `System`Pattern[System`rhs, System`Blank[]]] could not be associated to System`$TimeZone

  • System`Exit[System`Pattern[System`n, System`BlankNullSequence[]]] could not be associated to System`Quit

  • System`Normal[System`Pattern[System`dispatch, System`Blank[System`Dispatch]]] could not be associated to System`Dispatch

  • System`Normal[System`Pattern[System`dispatch, System`Blank[System`Dispatch]]] could not be associated to System`Dispatch

  • System`Read[System`Pattern[System`arg1, System`Blank[]], `System`Pattern[System`arg2, System`Blank[]]] could not be associated to System`Find

  • System`Read[System`Pattern[System`arg1, System`Blank[]], System`Pattern[System`arg2, System`Blank[]]] could not be associated to System`Find

  • System`Read[System`Pattern[System`stream, System`Blank[]]] could not be associated to System`Find

  • System`Read[System`Pattern[System`arg1, System`Blank[]], System`Pattern[System`arg2, System`Blank[]]] could not be associated to System`ReadList

  • System`Read[System`Pattern[System`arg1, System`Blank[]], System`Pattern[System`arg2, System`Blank[]]] could not be associated to

  • System`ReadList

  • System`Read[System`Pattern[System`arg1, System`Blank[]], System`Pattern[System`arg2, System`Blank[]]] could not be associated to System`Skip

  • System`Read[System`Pattern[System`arg1, System`Blank[]], System`Pattern[System`arg2, System`Blank[]]] could not be associated to System`Skip

  • System`Parition[System`Pattern[System`list, System`Blank[]], SystemPattern[Systemn, SystemBlank[]], SystemPattern[Systemd, SystemBlank[]], Systemk]``` could not be associated to ```SystemPartition```

  • System`DisplayForm[System`Pattern[System`boxexpr, System`Blank[System`IntepretationBox]]] could not be associated to System`InterpretationBox

  • System`ToExpression[System`Pattern[System`boxexpr, System`Blank[System`IntepretationBox]], System`Pattern[System`form, System`BlankNullSequence[]]] could not be associated to System`InterpretationBox

  • System`DisplayForm[System`Pattern[System`boxexpr, System`Blank[System`IntepretationBox]]] could not be associated to System`InterpretationBox

  • System`ToExpression[System`Pattern[System`boxexpr, System`Blank[System`IntepretationBox]], System`Pattern[System`form, System`BlankNullSequence[]]] could not be associated to System`InterpretationBox

* Improve ``mathics.core.definitions.get_tag_position`` to support more complex rules
* Add a pytest to check different cases of ``get_tag_position``
* Restore ``mathics.docpipeline`` from master~3, because the current one is not properly working.
@mmatera mmatera marked this pull request as ready for review March 13, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant