Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating Database of Ab Initio Crystal Structures (DAICS) to Optimade #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrating Database of Ab Initio Crystal Structures (DAICS) to Optimade #102

wants to merge 2 commits into from

Conversation

zxwtstar
Copy link

Integrating Database of Ab Initio Crystal Structures (DAICS) to Optimade. Z. Allahyari

@merkys
Copy link
Member

merkys commented Apr 26, 2024

Looks legit. By the way, structure_features values do not seem to conform to OPTIMADE standard, it would probably be better to use custom prefixed field for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA is a code owner

@ml-evs ml-evs Awaiting requested review from ml-evs ml-evs is a code owner

@merkys merkys Awaiting requested review from merkys merkys is a code owner

@rartino rartino Awaiting requested review from rartino rartino is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zxwtstar @merkys