Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX Makefile changes #218

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OSX Makefile changes #218

wants to merge 2 commits into from

Conversation

Digicrat
Copy link

See #174

@Digicrat Digicrat mentioned this pull request Mar 16, 2020
Open
@MatMoul
Copy link
Owner

MatMoul commented Apr 28, 2020

Duplicate with #193
Some diff but is g810-led working for OSX?

@aprovera
Copy link

aprovera commented May 6, 2020 •
edited

With the prerequisite dependency (brew install hidapi) installed, and after applying the makefile changes made by @Digicrat I can successfully compile it on OS X (v10.13).

sudo make install however does not work correctly because OS X doesn't allow users to mess with /usr/bin. /usr/local/bin would be the right install path in this case.

The software itself only appears to work correctly when run with sudo, however. When run without root privileges it returns a Matching or compatible device not found ! error.

Also worthy of note, OS X uses launchd instead of systemd. The way of having the utility start automatically on boot on OS X is making a Launch Daemon.

aprovera
aprovera reviewed May 6, 2020
View reviewed changes
makefile
debug: CXXFLAGS += -g -Wextra -pedantic
debug: bin/$(PROGN)

lib/lib$(PROGN).so: $(LIBSRCS)
@mkdir -p lib
$(CXX) $(CPPFLAGS) $(CXXFLAGS) $(LDFLAGS) -fPIC -shared -Wl,-soname,lib$(PROGN).so -o lib/lib$(PROGN).so.$(MAJOR).$(MINOR).$(MICRO) $^ $(LIBS)
$(CXX) $(CPPFLAGS) $(CXXFLAGS) $(LDFLAGS) -fPIC -shared $(LINKFLAGS) -o lib/lib$(PROGN).so.$(MAJOR).$(MINOR).$(MICRO) $^ $(LIBS)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be $(LINK_FLAGS) instead of $(LINKFLAGS)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprovera aprovera aprovera left review comments

Assignees
No one assigned
Labels
duplicate help wanted need investigation partially accepted review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Digicrat @MatMoul @aprovera